Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - tremor-script VM #2650

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

WIP - tremor-script VM #2650

wants to merge 13 commits into from

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Aug 8, 2024

Pull request

Description

Related

  • RFC
  • Related Issues: fixes #000, closed #000
  • Related docs PR

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@Licenser Licenser marked this pull request as draft August 8, 2024 19:05
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.13208% with 1572 lines in your changes missing coverage. Please review.

Project coverage is 78.08%. Comparing base (bff8093) to head (11500a3).

Files with missing lines Patch % Lines
tremor-script/src/vm/compiler/impls/imut_expr.rs 0.00% 565 Missing ⚠️
tremor-script/src/vm.rs 0.00% 467 Missing ⚠️
tremor-script/src/vm/compiler/impls.rs 0.00% 233 Missing ⚠️
tremor-script/src/vm/compiler.rs 0.00% 160 Missing ⚠️
tremor-script/src/vm/op.rs 0.00% 73 Missing ⚠️
tremor-script/src/vm/compiler/impls/mut_expr.rs 0.00% 49 Missing ⚠️
tremor-script/src/interpreter.rs 48.27% 15 Missing ⚠️
tremor-script/src/ast.rs 0.00% 3 Missing ⚠️
tremor-value/src/value.rs 0.00% 3 Missing ⚠️
tremor-script/src/ast/eq.rs 0.00% 2 Missing ⚠️
... and 1 more

❗ There is a different number of reports uploaded between BASE (bff8093) and HEAD (11500a3). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (bff8093) HEAD (11500a3)
unittests 17 15
tremorruntime 1 0
tremorscript 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2650       +/-   ##
===========================================
- Coverage   91.22%   78.08%   -13.15%     
===========================================
  Files         309      311        +2     
  Lines       60078    56398     -3680     
===========================================
- Hits        54805    44036    -10769     
- Misses       5273    12362     +7089
Flag Coverage Δ
e2e-command 10.87% <0.00%> (-0.42%) ⬇️
e2e-integration 48.56% <0.81%> (-1.84%) ⬇️
e2e-unit 12.10% <0.69%> (-0.48%) ⬇️
e2etests 50.80% <1.13%> (-1.93%) ⬇️
tremorapi 13.98% <0.00%> (-0.53%) ⬇️
tremorcodec 62.63% <0.00%> (-0.04%) ⬇️
tremorcommon 63.04% <ø> (ø)
tremorconnectors 27.67% <0.00%> (-1.20%) ⬇️
tremorconnectorsaws 10.70% <0.00%> (-0.58%) ⬇️
tremorconnectorsazure 4.45% <0.00%> (-0.25%) ⬇️
tremorconnectorsgcp 24.27% <0.00%> (-1.05%) ⬇️
tremorconnectorsobjectstorage 0.05% <0.00%> (-0.01%) ⬇️
tremorconnectorsotel 11.97% <0.00%> (-0.61%) ⬇️
tremorconnectorstesthelpers 68.25% <ø> (ø)
tremorinflux 87.71% <ø> (ø)
tremorinterceptor 54.25% <0.00%> (-0.04%) ⬇️
tremorpipeline 29.35% <0.18%> (-1.82%) ⬇️
tremorruntime ?
tremorscript ?
tremorsystem 5.38% <0.00%> (-0.40%) ⬇️
tremorvalue 69.45% <0.00%> (-0.10%) ⬇️
unittests 66.30% <0.18%> (-22.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tremor-script/src/ast/binary.rs 30.45% <100.00%> (-68.21%) ⬇️
tremor-script/src/ast/raw.rs 67.28% <100.00%> (-30.26%) ⬇️
...emor-script/src/ast/visitors/impls/const_folder.rs 64.44% <100.00%> (-33.07%) ⬇️
tremor-script/src/errors.rs 20.52% <ø> (-49.19%) ⬇️
tremor-script/src/interpreter/imut_expr.rs 55.30% <100.00%> (-34.86%) ⬇️
tremor-script/src/lib.rs 100.00% <ø> (ø)
tremor-script/src/script.rs 93.87% <ø> (-0.25%) ⬇️
tremor-script/src/ast/eq.rs 7.34% <0.00%> (-88.51%) ⬇️
tremor-script/src/extractor/re.rs 0.00% <0.00%> (-91.43%) ⬇️
tremor-script/src/ast.rs 57.60% <0.00%> (-35.36%) ⬇️
... and 8 more

... and 103 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff8093...11500a3. Read the comment docs.

@Licenser
initial state
2f8f844 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
Some match support
23228a2 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
patch default
bdbc287 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
Restructure
a4c182a 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
nested assignments
f128fc1 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
patch mergee key
6aadc15 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
Add support for default and a first loop
6d37d71 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
More pattern matching
f4d1758 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
Touple expressions and compiler comments
d959731 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
Tree search pattern matcher
85f12a3 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
Allow assignments in match patterns
f53b130 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
Add support for record patterns
0333365 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser
some matchy vm stuff
11500a3 
Signed-off-by: Heinz N. Gies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darach darach Awaiting requested review from darach darach is a code owner

@mfelsche mfelsche Awaiting requested review from mfelsche mfelsche is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Licenser